Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated APIs #401

Merged
merged 7 commits into from
Apr 25, 2022
Merged

Replace deprecated APIs #401

merged 7 commits into from
Apr 25, 2022

Conversation

offa
Copy link
Contributor

@offa offa commented Apr 7, 2022

Replacement of some deprecated APIs and migration of try-fail-catch based test cases to assertThrows().

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jglick jglick added the chore label Apr 22, 2022
offa and others added 4 commits April 25, 2022 06:26
@offa @jglick
Add assertion message
45b9726 
Co-authored-by: Jesse Glick <[email protected]>
@offa @jglick
Fix exception type
eb5c4ec 
Co-authored-by: Jesse Glick <[email protected]>
@offa @jglick
Use try-with-resource
e542279 
Co-authored-by: Jesse Glick <[email protected]>
@offa @jglick
Fix exception type
c4a9389 
Co-authored-by: Jesse Glick <[email protected]>
jglick
jglick reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict

@offa
Copy link
Contributor Author

offa commented Apr 25, 2022

Resolved 👍

@jglick jglick merged commit 0e7c803 into jenkinsci:master Apr 25, 2022
@offa offa deleted the deprecated_apis branch April 26, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@offa @jglick